BigQuery: enable FROM-first SELECT - #2439
Merged
Merged
Conversation
BigQuery allows a query to start with `FROM`, e.g. `FROM t` and `FROM t SELECT *`, which is also the entry form for pipe syntax (`FROM t |> ...`). The parser already supports FROM-first `SELECT` behind `Dialect::supports_from_first_select()` (enabled for ClickHouse, DuckDB and Generic); this enables it for BigQuery as well. The existing `test_select_from_first` / `test_select_from_first_with_cte`, parameterized over `all_dialects_where(|d| d.supports_from_first_select())`, now cover BigQuery. Docs: https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#from_queries Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
LucaCappelletti94
suggested changes
Aug 18, 2026
LucaCappelletti94
left a comment
LucaCappelletti94
left a comment
Contributor
There was a problem hiding this comment.
Include tests for the big query dialect to avoid regressions.
Add regression tests for the BigQuery dialect's FROM-first `SELECT`: the bare `FROM t` (`FromFirstNoSelect`) and `FROM t SELECT ...` (`FromFirst`) forms, and `FROM t |> ...` as the entry form for pipe syntax. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
Done. |
iffyio
reviewed
Aug 19, 2026
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-authored-by: Ifeanyi Ubah <ify1992@yahoo.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
iffyio
approved these changes
Aug 20, 2026
iffyio
left a comment
iffyio
left a comment
Contributor
There was a problem hiding this comment.
LGTM! Thanks @moshap-firebolt!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigQuery allows a query to start with
FROM, e.g.FROM tandFROM t SELECT *,which is also the entry form for pipe syntax (
FROM t |> ...).The parser already supports FROM-first
SELECTbehindDialect::supports_from_first_select()(enabled for ClickHouse, DuckDB andGeneric); this enables it for BigQuery as well. The existing
test_select_from_first/test_select_from_first_with_cte, parameterized overall_dialects_where(|d| d.supports_from_first_select()), now cover BigQuery.Docs: https://cloud.google.com/bigquery/docs/reference/standard-sql/query-syntax#from_queries